[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN VMID PATCH 1/2] xen/arm: Move p2m_vmid_allocator_init() inside setup_virt_paging()





On 13/12/16 14:06, Julien Grall wrote:
Hi Bhupinder,

On 12/12/16 07:26, Bhupinder Thakur wrote:
Since VMIDs are related to 2nd stage address translation, it makes
more sense
to move the call to p2m_vmid_allocator_init(), which initializes the vmid
allocation bitmap, inside setup_virt_paging(), where 2nd stage address
translation
is set up.

Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Actually, one minor change. The function p2m_vmid_allocator_init does not need to be exported anymore. So can you please make it static?

With that, you can keep my reviewed-by tag.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.