Re: [Xen-devel] [PATCH V5] x86/vm_event: Added support for VM_EVENT_REASON_INTERRUPT

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 12/13/2016 03:18 PM, Jan Beulich wrote:
>>>> On 13.12.16 at 09:50, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> On 11/17/2016 07:11 AM, Tian, Kevin wrote:
>>>> From: Razvan Cojocaru [mailto:rcojocaru@xxxxxxxxxxxxxxx]
>>>> Sent: Wednesday, November 16, 2016 3:49 PM
>>>>
>>>> On 11/16/2016 09:22 AM, Tian, Kevin wrote:
>>>>> Looks not working with APICv virtual interrupt delivery...
>>>>
>>>> It's only meant to work with "regular" injections (we'd like to be able
>>>> to tell if xc_hvm_inject_trap() can succeed). APICv support could be a
>>>> later patch, if desirable (AFAICT, the two types shouldn't collide, i.e.
>>>> impede trap delivery as done by the xc_hvm_inject_trap() hypercall).
>>>>
>>>>
>>>
>>> OK then. Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>>
>> AFAIK this has been acked by everyone a while back, is further action
>> required on my part, or is just low in the patch queue?
> 
> Before asking, did you check the patch still applies and builds?
> I've taken the time to make it apply, but it really needs more
> than that. Please re-base.

While re-basing the patch on staging, I've got this (unrelated) error
while doing 'make dist':

make[9]: Entering directory `~/work/xen.git/tools/firmware/rombios/32bit'
gcc   -m32 -march=i686 -DBUILD_ID -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O0 -g3
-fno-omit-frame-pointer
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
.util.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-mno-tls-direct-seg-refs  -Werror -fno-stack-protector -fno-exceptions
-fno-builtin -msoft-float
-I/home/red/work/xen.git/tools/firmware/rombios/32bit/../../../../tools/include
-I.. -I../../../libacpi  -c -o util.o util.c
util.c: In function ‘get_s3_waking_vector’:
util.c:453:23: error: dereferencing pointer to incomplete type
     if (!fadt || (fadt->header.signature != ACPI_2_0_FADT_SIGNATURE))
                       ^
util.c:453:45: error: ‘ACPI_2_0_FADT_SIGNATURE’ undeclared (first use in
this function)
     if (!fadt || (fadt->header.signature != ACPI_2_0_FADT_SIGNATURE))
                                             ^
util.c:453:45: note: each undeclared identifier is reported only once
for each function it appears in
util.c:456:45: error: dereferencing pointer to incomplete type
     facs = (struct acpi_20_facs *)(long)fadt->x_firmware_ctrl;
                                             ^
make[9]: *** [util.o] Error 1

I'm not where this is best reported, but thought someone might like to know.


Thanks,
Razvan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel