Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH v2 6/9] ts-xen-build: Build the livepatch 
test-cases"):
> +    buildcmd_stamped_logged(600, 'xen', 'xenlpt-build', '',<<END,'') if 
> $dokconfig;
> +        if test -d xen/test; then
> +            $make_prefix make -C xen tests
> +        fi

Is $dokconfig really the right test for whether the livepatch build
should be attempted ?  It seems like a rather arbitrary connection.

> +    buildcmd_stamped_logged(600, 'xen', 'xenlpt-install', '',<<END,'') if 
> $dokconfig;
> +        if test -d xen/test; then
> +           mkdir -p dist/xenlptinstall/usr/lib/debug
> +           livepatch_files=`find xen/test/livepatch -name '*.livepatch' 
> -print`
> +           cp \$livepatch_files dist/xenlptinstall/usr/lib/debug
> +        fi

As I say, I don't much like this.  There's a conversation ongoing
about it.

>  sub stash () {
> -    foreach my $part ('', 'xen') {
> +    foreach my $part ('', 'xen', 'xenlpt') {
>       if (target_dir_exists($ho, "$builddir/xen/dist/${part}install")) {
>               built_stash($ho, $builddir,

I don't much like this approach.  It might result in deferring certain
failures undesirably.

Also, I don't know why it is necessary to look on the build box for
this information.  ts-xen-build ought to know whether it has run `make
xenlpt-tests-install' (or whatever it is), so it ought to simply know
whether to do the build_stash.

You could instead do something like

    our %skip_stash_part;
    ...
    if (some condition) {
        make xenlpt-install
    } else {
        $skip_stash_part{xenlpttest}= 1;
    }
    ...
    next if $skip_stash_part{$part}

or an ad-hoc variable, giving

    next if $part eq $xenlpttest && !$do_xenlpt;

or something ?

Thanks
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel