Re: [Xen-devel] [PATCH v2] VT-d: correct dma_msi_set_affinity()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/12/16 15:53, Jan Beulich wrote:
> Commit 83cd2038fe ("VT-d: use msi_compose_msg()) together with
> 15aa6c6748 ("amd iommu: use base platform MSI implementation"),
> introducing the use of a per-CPU scratch CPU mask, went too far:
> dma_msi_set_affinity() may, at least in theory, be called in
> interrupt context, and hence the use of that scratch variable is not
> correct.
>
> Since the function overwrites the destination information anyway,
> allow msi_compose_msg() to be called with a NULL CPU mask, avoiding
> the use of that scratch variable.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel