Re: [Xen-devel] [PATCH v2] x86/emul: Simplfy L{ES, DS, SS, FS, GS} handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.12.16 at 18:10, <andrew.cooper3@xxxxxxxxxx> wrote:
> %ss, %fs and %gs can be calculated by directly masking the opcode.  %es and
> %ds cant, but the calculation isn't hard.
> 
> Use seg rather than dst.val for storing the calculated segment, which is
> appropriately typed.  Drop the sel local variable entirely and use dst.val
> instead.  The mode_64bit() check can be repositioned and simplified to drop
> the ext check.  Replace opencoding of X86EMUL_OKAY.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel