Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Dec 16, 2016 at 10:10:43AM -0500, Boris Ostrovsky wrote:
> On 12/14/2016 06:49 AM, Andrew Cooper wrote:
> > On 14/12/16 11:44, Wei Liu wrote:
> >> ... otherwise it returns 0 even if the function fails.
> >
> > Coverity-ID: 1397121
> >
> >> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >
> >> ---
> >> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >>
> >> This should be backported to 4.8.
> >> ---
> >>  tools/libxl/libxl_x86_acpi.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c
> >> index 686ac8e..6cf0c30 100644
> >> --- a/tools/libxl/libxl_x86_acpi.c
> >> +++ b/tools/libxl/libxl_x86_acpi.c
> >> @@ -154,7 +154,7 @@ static int init_acpi_config(libxl__gc *gc,
> >>      config->acpi_revision = 5;
> >>  
> >>  out:
> >> -    return 0;
> >> +    return rc;
> 
> This breaks init_acpi_config(): xc_domain_getinfo() at the top of
> returns a positive number (number of domains).
> 

I see, I think we also need to set rc=0 in the success path.

Wei.

> -boris
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel