Re: [Xen-devel] [PATCH v5 03/13] domctl: Add XEN_DOMCTL_acpi_access

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.12.16 at 15:48, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 12/19/2016 09:17 AM, Jan Beulich wrote:
>>>>> On 17.12.16 at 00:18, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/domctl.c
>>> +++ b/xen/arch/x86/domctl.c
>>> @@ -1425,6 +1425,15 @@ long arch_do_domctl(
>>>          }
>>>          break;
>>>  
>>> +    case XEN_DOMCTL_acpi_access:
>>> +        if ( !is_hvm_domain(d) )
>>> +            ret = -EINVAL;
>> I think it would be better to use some other, less frequently used
>> error code here.
> 
> ENODEV? (Because there is no ACPI "device" for PV guests)

Fine with me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel