[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking



On Sat, Dec 17, 2016 at 7:51 AM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx>
>
>
> Why?

Hey Konrad,

The problem that I have is that we build Xen releases in buildroot. As
things change (GCC version usually) new warnings are generated for
issues that previously never caused any problems. Instead of
constantly fixing these small warnings it is easier to disable Werror.

I understand that for development this isn't what you want. I just
thought it was worth at least sending this up.

Maybe a way to disable Werror when configuring would be the best solution?

Thanks,

Alistair

>
> Thanks!
>> ---
>>  Config.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Config.mk b/Config.mk
>> index 3ec7367..e3cda81 100644
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y
>>  SHELL     ?= /bin/sh
>>
>>  # Tools to run on system hosting the build
>> -HOSTCFLAGS  = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
>> +HOSTCFLAGS  = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
>>  HOSTCFLAGS += -fno-strict-aliasing
>>
>>  DISTDIR     ?= $(XEN_ROOT)/dist
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.