Re: [Xen-devel] [PATCH 2/2] x86/emul: Bugfixes to SYSCALL emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.12.16 at 17:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> Introduce vendor_is() to allow emulation to have vendor-specific
> behaviour.  Adjust the SYSCALL behaviour on Intel to raise #UD when
> executed outside of 64bit mode.

I'd rather not see us go this route. I've been carrying a patch
making the vendor an input (not submitted so far due to other
at least contextual prereqs missing when I last check, but sent
out just a minute ago). What do you think?

> in_longmode() has different return semantics from rc, so use a separate
> integer for the purpose.

The ugliness of the additional #ifdef doesn't seem to warrant
this. What I've been thinking the other day though is: Why
don't we put the whole SYSCALL emulation into a __XEN__
conditional (implying __x86_64__, i.e. allowing the inner ones
to be removed)? That would likely also limit the impact of the
pending register name changes which I hope to be able to
submit soon (once enough prereqs have gone in).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel