Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

[Alistair Francis <alistair23@xxxxxxxxx>]

On Tue, Dec 20, 2016 at 9:21 AM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote:
>> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
>> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
>> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
>> >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>> >>>> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx>
>> >>>
>> >>>
>> >>> Why?
>> >>
>> >> *adjusts his distro maintainer hat* It's considered really bad form for
>> >> upstreams to push -Werror in their projects. However I know there's
>> >> upstream interest to keep it. The compromise would probably be to get my
>> >> rear in gear and get a wider range of distros testing with Travis CI /
>> >> GitLab CI.
>> >
>> > So.. why not do something like this:
>> >
>> >
>> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
>> > index 6be8233..fd2d5b9 100644
>> > --- a/config/StdGNU.mk
>> > +++ b/config/StdGNU.mk
>> > @@ -39,3 +39,5 @@ ifeq ($(lto),y)
>> >  CFLAGS += -flto
>> >  LDFLAGS-$(clang) += -plugin LLVMgold.so
>> >  endif
>> > +
>> > +CFLAGS += $(EXTRA_CFLAGS)
>> >
>> > And have the BuildRoot script do something like:
>> >
>> >
>> > EXTRA_CFLAGS=$(CFLAGS)
>> > unset CFLAGS
>> >
>> > make -C xen
>> >
>> > ?
>> >
>>
>> This was really to replace patch 3/7 right? Cause I think this would be
>> an ok change. It'd certainly help me with Yocto where I have to pass in
>> CFLAGS (need to pass in the sysroot of the target compiler).
>
> Yes sorry.

Yeah, this could work as well (for patch 3).

Should I re-spin with something like that?

Thanks,

Alistair

>>
>> --
>> Doug Goldstein
>>
>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel