Re: [Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.12.16 at 18:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/12/2016 10:39, Jan Beulich wrote:
>> @@ -3032,16 +3032,16 @@ void hvm_task_switch(
>>      if ( hvm_set_cr3(tss.cr3, 1) )
>>          goto out;
>>  
>> -    regs->eip    = tss.eip;
>> -    regs->eflags = tss.eflags | 2;
>> -    regs->eax    = tss.eax;
>> -    regs->ecx    = tss.ecx;
>> -    regs->edx    = tss.edx;
>> -    regs->ebx    = tss.ebx;
>> -    regs->esp    = tss.esp;
>> -    regs->ebp    = tss.ebp;
>> -    regs->esi    = tss.esi;
>> -    regs->edi    = tss.edi;
>> +    regs->rip    = tss.eip;
>> +    regs->rflags = tss.eflags | 2;
> 
> As you are modifying this anyway, mind avoiding this opencoding?

Oh, sure - should have paid attention myself.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel