Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

[Alistair Francis <alistair.francis@xxxxxxxxxx>]

On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 20.12.16 at 20:46, <alistair.francis@xxxxxxxxxx> wrote:
>> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx>
>
> Without some rationale given I don't think such changes are
> acceptable at all. And then, as already pointed out others, the
> use of -Werror is there not just for fun. If anything I think an
> override to that default could be acceptable.

Unfortunately the APPEND_CFLAGS=-Wno-error doesn't fix all the issues
as I still see warnings/errors when building: tools/kconfig/conf.c.

I understand that you want it in by default.

Everyone seems fairly open to an override. Is a environment variable,
which if set will disable Werror acceptable? Something like NO_ERROR=Y
which will result in no -Werror being appended.

Thanks,

Alistair

>
> Jan
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel