Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> "Tian, Kevin" <kevin.tian@xxxxxxxxx> 12/23/16 6:48 AM >>>
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Thursday, December 22, 2016 11:37 PM
>> >>> On 22.12.16 at 16:14, <andrew.cooper3@xxxxxxxxxx> wrote:
>> > My argument is that, instead of excluding the hook, the behaviour of the
>> > emulation path should be made to function sensibly even on hardware
>> > without vmfunc.
>> >
>> > i.e. drop the cpu_has_vmx_vmfunc check and do nothing else.
>> 
>> Ah, I see. I guess I'll leave that to someone having an environment
>> to test this. The patch's goal was to not change observable behavior.
> 
>If later we'll have to again get hook always installed (for hardware w/o 
>vmfunc), I'm hesitant to ack this version...

While I can understand that response of yours, may I then ask that you
(the VMX maintainers) submit a patch to follow Andrew's outline (unless
he means to do so himself).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel