[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC PATCH 0/9] Introduce AMD SVM AVIC
On 12/22/16 18:38, Jan Beulich wrote: On 19.09.16 at 07:52, <suravee.suthikulpanit@xxxxxxx> wrote:Suravee Suthikulpanit (9): x86/HVM: Introduce struct hvm_pi_ops x86/vLAPIC: Declare vlapic_read_aligned() and vlapic_reg_write() as non-static x86/HVM: Call vlapic_destroy after vcpu_destroy x86/SVM: Modify VMCB fields to add AVIC support x86/HVM/SVM: Add AVIC initialization code x86/SVM: Add AVIC vmexit handlers x86/SVM: Add vcpu scheduling support for AVIC x86/SVM: Add interrupt management code via AVIC x86/SVM: Hook up miscellaneous AVIC functionsApart from the small comments on the individual patches I've just given, there are a number of cosmetic issues which will need dealing with, like coding style, use of plain int when unsigned int is meant, use of bool_t (or even plain int) when elsewhere you already properly use bool, and perhaps some constification. And I'm sorry for it having taken so long to get to look over this series. Jan Thanks for your review comment. I know you are busy. Your time is greatly appreciated. Konrad has also pointed out several styling issue which I have been making changes. I'll test and send out the V2. S _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |