Re: [Xen-devel] [PATCH] x86emul: use unambiguous register names

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.01.17 at 15:12, <JBeulich@xxxxxxxx> wrote:
>>>> On 03.01.17 at 14:30, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 03/01/17 13:01, Jan Beulich wrote:
>>> @@ -2716,36 +2716,36 @@ x86_emulate(
>>>          struct segment_register cs, sreg;
>>>  
>>>      case 0x00 ... 0x05: add: /* add */
>>> -        emulate_2op_SrcV("add", src, dst, _regs.eflags);
>>> +        emulate_2op_SrcV("add", src, dst, _regs.r(flags));
>>>          break;
>>>  
>> 
>> All of these types of operations only adjust the arithmetic flags, so
>> could legitimately use eflags alone.  Is it worth reducing?
> 
> Yes, but not now and here: Using _eflags breaks the inline asm which
> these macros resolve to.

Actually, after some staring at those macros I think this might be
relatively simple to deal with, so let me see if I can put together a
prereq patch allowing _eflags to be used here instead.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel