Re: [Xen-devel] [PATCH v6 02/12] x86/save: public/arch-x86/hvm/save.h is available to hypervisor and tools only

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.01.17 at 15:04, <boris.ostrovsky@xxxxxxxxxx> wrote:
> Noone else needs to include it since it is only useful to code
> that can made domctl calls. And public domctl.h can only be included
> by the toolstack or the hypervisor.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
> New in v6 (not required by the series).
> 
> Q: Should include/public/hvm/save.h have the same guards?

Yes. In fact the architecture specific header should never be included
directly, so putting the guard just there (and ...

> --- a/xen/include/public/arch-x86/hvm/save.h
> +++ b/xen/include/public/arch-x86/hvm/save.h
> @@ -26,6 +26,8 @@
>  #ifndef __XEN_PUBLIC_HVM_SAVE_X86_H__
>  #define __XEN_PUBLIC_HVM_SAVE_X86_H__
>  
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)

... an #error here and in the ARM counterpart) would seem best.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel