Re: [Xen-devel] [PATCH v5] x86/apicv: fix RTC periodic timer and apicv issue

["Xuquan (Quan Xu)" <xuquan8@xxxxxxxxxx>]

On January 05, 2017 10:38 AM, Tian, Kevin wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Wednesday, January 04, 2017 8:57 PM
>>
>> >>> On 04.01.17 at 13:21, <xuquan8@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/hvm/vmx/intr.c
>> > +++ b/xen/arch/x86/hvm/vmx/intr.c
>> > @@ -334,7 +335,8 @@ void vmx_intr_assist(void)
>> >              __vmwrite(EOI_EXIT_BITMAP(i),
>v->arch.hvm_vmx.eoi_exit_bitmap[i]);
>> >          }
>> >
>> > -        pt_intr_post(v, intack);
>> > +        if ( intack.vector == pt_vector )
>> > +            pt_intr_post(v, intack);
>>
>> ... this change doesn't appear to be mentioned in the description at
>> all, and I can't see why it is needed considering the is_pt_irq()
>> check (under lock) early on in pt_intr_post().
>
>yes, duplicated check here.
>

Agreed, drop it in next v6.

Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel