Re: [Xen-devel] [PATCH v2 01/10] x86/HVM: Introduce struct hvm_pi_ops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.01.17 at 03:54, <kevin.tian@xxxxxxxxx> wrote:
>>  From: Suravee Suthikulpanit [mailto:suravee.suthikulpanit@xxxxxxx]
>> Sent: Saturday, December 31, 2016 1:46 PM
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -204,12 +204,12 @@ void vmx_pi_hooks_assign(struct domain *d)
>>      if ( !iommu_intpost || !has_hvm_container_domain(d) )
>>          return;
>> 
>> -    ASSERT(!d->arch.hvm_domain.vmx.vcpu_block);
>> +    ASSERT(!d->arch.hvm_domain.pi_ops.vcpu_block);
>> 
>> -    d->arch.hvm_domain.vmx.vcpu_block = vmx_vcpu_block;
>> -    d->arch.hvm_domain.vmx.pi_switch_from = vmx_pi_switch_from;
>> -    d->arch.hvm_domain.vmx.pi_switch_to = vmx_pi_switch_to;
>> -    d->arch.hvm_domain.vmx.pi_do_resume = vmx_pi_do_resume;
>> +    d->arch.hvm_domain.pi_ops.vcpu_block = vmx_vcpu_block;
>> +    d->arch.hvm_domain.pi_ops.pi_switch_from = vmx_pi_switch_from;
>> +    d->arch.hvm_domain.pi_ops.pi_switch_to = vmx_pi_switch_to;
>> +    d->arch.hvm_domain.pi_ops.pi_do_resume = vmx_pi_do_resume;
>>  }
>> 
> 
> what about removing pi_ prefix from callbacks given that they are
> all under pi_ops?

+1

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel