Re: [Xen-devel] [PATCH v2 2/2] build: use debug_symbols to add -g3

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v2 2/2] build: use debug_symbols to add -g3"):
> On Tue, Jan 03, 2017 at 02:07:31AM -0700, Jan Beulich wrote:
> > On 23.12.16 at 13:24, <wei.liu2@xxxxxxxxxx> wrote:
> > > @@ -146,7 +146,7 @@ SHLIB_libxenvchan  = $(SHDEPS_libxenvchan) 
> > > -Wl,-rpath-link=$(XEN_LIBVCHAN)
> > >  
> > >  ifeq ($(debug),y)
> > >  # Disable optimizations and enable debugging information for macros
> > > -CFLAGS += -O0 -g3 -fno-omit-frame-pointer
> > > +CFLAGS += -O0 -fno-omit-frame-pointer
> > 
> > I think you want to also adjust the comment then.
> > 
> 
> I think I will just change the comment to:
> 
>   # Disable optimizations

With that change,

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel