Re: [Xen-devel] [PATCH] x86/VMX: Implement vmptrst

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.01.17 at 19:42, <anshul.makkar@xxxxxxxxxx> wrote:
> +static always_inline u64 __vmptrst(void)
> +{
> +    u64 paddr;
> +
> +    asm volatile (
> +#ifdef HAVE_GAS_VMX
> +                   "vmptrst %0\n"
> +#else
> +                   VMPTRST_OPCODE MODRM_EAX_07
> +#endif
> +
> +#ifdef HAVE_GAS_VMX
> +                   : "=m" (paddr)
> +                   :
> +#else
> +                   :
> +                   : "a" (&paddr),
> +#endif
> +                   : "memory");

I don't see the point of the memory clobber here in the
HAVE_GAS_VMX case (and in the other case it could be easily
avoided by making the output common). In fact some time ago I
did raise the question already as to whether some of the other
inline functions shouldn't also be relaxed.

Also there's a missing blank before the closing parenthesis.

Beyond that I'll leave it to the VMX maintainers to decide whether
having an unused function in the code base is a good idea.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel