[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 02/25] x86/cpuid: Introduce struct cpuid_policy



>>> On 09.01.17 at 17:08, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/01/17 15:15, Jan Beulich wrote:
>>>>> On 09.01.17 at 12:03, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> +    /* Extended leaves. */
>>> +    cpuid_leaf(0x80000000, &p->extd.raw[0]);
>>> +    for ( i = 1; i < min(ARRAY_SIZE(p->extd.raw),
>>> +                         p->extd.max_leaf + 1 - 0x80000000ul); ++i )
>> Would it be worthwhile to make the code resilient to max_leaf not
>> having the high bit set?
> 
> I'm tempted not to.  If we didn't have sensible higher leaves, we would
> have failed the LM check in head.S and failed to boot.

Good point.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.