Re: [Xen-devel] [PATCH v11 01/13] x86: add multiboot2 protocol support

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 1/10/17 2:38 AM, Jan Beulich wrote:
>>>> On 10.01.17 at 02:21, <cardoe@xxxxxxxxxx> wrote:
>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>>> +/* Flags set in the 'flags' member of the multiboot header.  */
>>> +#define MULTIBOOT2_TAG_TYPE_END                            0
>>> +#define MULTIBOOT2_TAG_TYPE_CMDLINE                        1
>>> +#define MULTIBOOT2_TAG_TYPE_BOOT_LOADER_NAME               2
>>> +#define MULTIBOOT2_TAG_TYPE_MODULE                 3
>>> +#define MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO          4
>>> +#define MULTIBOOT2_TAG_TYPE_BOOTDEV                        5
>>> +#define MULTIBOOT2_TAG_TYPE_MMAP                   6
>>> +#define MULTIBOOT2_TAG_TYPE_VBE                            7
>>> +#define MULTIBOOT2_TAG_TYPE_FRAMEBUFFER                    8
>>> +#define MULTIBOOT2_TAG_TYPE_ELF_SECTIONS           9
>>> +#define MULTIBOOT2_TAG_TYPE_APM                            10
>>
>> Nitpicky but it would be nice if these lined up.
> 
> Well, the question is what tab width you expect them to line up
> with - with tab == 8 spaces they do line up for me.
> 
> Also - please trim your quotes in replies.
> 
> Jan
> 

Well given that this is a new file and CODING_STYLE says spaces over
tabs and to treat indent level as 4 spaces. That was what my assumption was.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel