[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 0/2] XEN SWIOTLB for ARM dma operations extension



Dear Konrad,

Please see my comments below:
It would be good to have that as part of this patchset, otherwise
this is kind of non-compiling type patch.
I'm not really sure what do you mean.
The patch I refer was done for LK 3.4 if I remember, it is not applicable to 4.6 I'm currently working with. Moreover xen-swiotlb infrastructure changed significantly so the patch is completely reworked. The only
common code is that mmap is defined in ARM specific xen_swiotlb_dma_ops.
I just refer to it and left author and signed-of-s as a respect to the work done few years ago.

But more importantly, I think you need to also to take into account
Stefano's comments:
I've encapsulated all the code changes in an arch/arm/xen/mm.c so I don't think your doubts and Stephano's comment
about x86 build impact is relevant here.

--

*Andrii Anisov*

*Lead Systems Engineer*

*Office: *+380 44 390 5457 <tel:+380%2044%20390%205457> *x* 66766 <tel:66766>*Cell: *+380 50 5738852 <tel:+380%2050%205738852>*Email: *andrii_anisov@xxxxxxxx <mailto:andrii_anisov@xxxxxxxx>

*Kyiv**,* *Ukraine *(GMT+3)*epam.com <http://www.epam.com>*

CONFIDENTIALITY CAUTION AND DISCLAIMER
This message is intended only for the use of the individual(s) or entity(ies) to which it is addressed and contains information that is legally privileged and confidential. If you are not the intended recipient, or the person responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. All unintended recipients are obliged to delete this message and destroy any printed copies.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.