[Xen-devel] [PATCH] x86/sysctl: Fix NULL pointer dereference in error path

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

This was introduced by c/s c38869e711 "x86/cpuid: Drop the temporary linear
feature bitmap from struct cpuid_policy", and caught by Coverity.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
---
 xen/arch/x86/sysctl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index 87da541..274ca0c 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -229,7 +229,10 @@ long arch_do_sysctl(
 
         /* Bad featureset index? */
         if ( !p )
+        {
             ret = -EINVAL;
+            break;
+        }
 
         cpuid_policy_to_featureset(p, featureset);
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel