Re: [Xen-devel] [PATCH v3 8/8] x86/hvm: serialize trap injecting producer and consumer

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.01.17 at 17:28, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 12/01/17 14:58, Paul Durrant wrote:
>> Since injection works on a remote vCPU, and since there's no
>> enforcement of the subject vCPU being paused, there's a potential race
>> between the producing and consuming sides. Fix this by leveraging the
>> vector field as synchronization variable.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> [re-based]
>> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
>> ---
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> This looks fairly unrelated to the other dm changes.  Given that it is a
> backport candidate, should it be pulled ahead of the move to dm.c?  (I
> can make this happen on commit if we are in agreement).

This indeed was the case from the very beginning of the HVMOP
series, and I've never done the re-order because I had never
expected it to take so long for the earlier patches to go in. And
admittedly I was also too lazy (or should I say too busy, to make
it sound better) to do that re-ordering, as the fix didn't seem
important enough to bother (I'm not sure why you think this
would be a backporting candidate, as I don't think this hypercall
is used by anything that's in fully supported state).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel