Re: [Xen-devel] [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2017-01-12 at 18:08 +0000, George Dunlap wrote:
> On Tue, Jan 19, 2016 at 2:35 PM, Ian Jackson
> <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> > 
> > > On Tue, 2016-01-19 at 14:06 +0000, Ian Jackson wrote:
> > > > 
> > > >  * XEN_DOMCTL_PSR_CAT_OP_SET_L3_* (public/domctl.h)
> > > >  * enum xc_psr_cat_type (xenctrl.h)
> > > >  * Enumeration("psr_cbm_type",...) (libxl_types.idl)
> > > 
> > > Forgot to say in my other reply, but we could try and abolish at
> > > least the
> > > xc one and have libxl internally use the domctl values.
> > 
> > Yes.
> > 
> > I like George's IDL suggestion.
> 
> Out of curiosity, did anything ever come of this?  
>
AFAICT, no. The patch with the casts was not taken, and we still have
all the three enums/types in Xen, libxc and libxl.

> If not it seems
> like we should write it down somewhere.
> 
Indeed, especially because it was a good idea.

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel