Re: [Xen-devel] [PATCH 4/4] x86/cpuid: Move the legacy cpuids array into struct cpuid_policy

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.01.17 at 18:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> This hides the legacy details inside the cpuid subsystem, where they will
> eventually be dropped entirely.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -503,7 +503,7 @@ static bool emulation_flags_ok(const struct domain *d, 
> uint32_t emflags)
>  int arch_domain_create(struct domain *d, unsigned int domcr_flags,
>                         struct xen_arch_domainconfig *config)
>  {
> -    int i, paging_initialised = 0;
> +    int paging_initialised = 0;

But please consider taking the opportunity to change this to bool.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel