Re: [Xen-devel] [PATCH v2] kexec: implement STATUS hypercall to check if image is loaded

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.17 at 12:40, <daniel.kiper@xxxxxxxxxx> wrote:
> On Fri, Jan 13, 2017 at 04:16:01AM -0700, Jan Beulich wrote:
>> >>> On 12.01.17 at 22:59, <eric.devolder@xxxxxxxxxx> wrote:
>> > CC: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
>> > CC: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
>>
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> (as the kexec maintainer)
>>
>> > Note: The __XEN_LATEST_INTERFACE_VERSION__ has been bumped to
>> > 0x00040900 due to the introduction of a new hypervisor call.
>>
>> This bumping is required only if something changes in the interface
>> such that e.g. source code would need adjustment to not fail to
>> build.
> 
> We need a check in kexec-tools to verify that STATUS hypercall
> is available. Otherwise we can disable relevant functionality.
> I thought that we can do that because __XEN_LATEST_INTERFACE_VERSION__
> is exposed via public headers.

No, you should check for KEXEC_CMD_kexec_status being defined
instead. That'll also cover someone backporting the change to their
packages.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel