Re: [Xen-devel] [PATCH 4/6] tools/libxc: Remove xsave calculations from libxc

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jan 16, 2017 at 11:40:28AM +0000, Andrew Cooper wrote:
> libxc performs a lot of calculations for the xstate leaf when generating a
> guests cpuid policy.  To correctly construct a policy for an HVM guest, this
> logic depends on native cpuid leaking through from real hardware.
> 
> In particular, the logic is potentially wrong for an HVM-based toolstack
> domain (e.g. PVH dom0), and definitely wrong if cpuid faulting is applied to a
> PV domain.
> 
> Xen now performs all the necessary calculations, using native values.  The
> only piece of information the toolstack need worry about is single xstate
> feature leaf.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxc/xc_cpuid_x86.c | 143 
> +++++----------------------------------------
>  1 file changed, 15 insertions(+), 128 deletions(-)
> 

I like this diffstat.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel