Re: [Xen-devel] [PATCH V3] x86/HVM: Introduce struct hvm_pi_ops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.01.17 at 14:38, <Suravee.Suthikulpanit@xxxxxxx> wrote:
> So, what if I generalize and simplify as following:
> 
> +/*
> + * This structure defines function hooks to support hardware-assisted
> + * virtual interrupt delivery to guest. (e.g. VMX PI and SVM AVIC).
> + *
> + * These hooks are defined by the underlying arch-specific code
> + * as needed. For example:
> + *   - When the domain is enabled with virtual IPI delivery
> + *   - When the domain is enabled with virtual I/O int delivery
> + *     and actually has a physical device assigned .
> + */
> +struct hvm_pi_ops {
> +    /* We add hooks into ctx_switch_from. */
> +    void (*switch_from) (struct vcpu *v);
> +
> +    /* We add hooks into ctx_switch_to */
> +    void (*switch_to) (struct vcpu *v);
> +
> +    /*
> +     * We add a new arch hook, arch_vcpu_block(),
> +     * which is called from vcpu_block() and vcpu_do_poll().
> +     */
> +    void (*vcpu_block) (struct vcpu *);
> +
> +    /* We add a hook on the vmentry path. */
> +    void (*do_resume) (struct vcpu *v);
> +};

Mostly fine, but please without the "We add" beginnings. Just
"Hook in ..." or some such. And please omit the stray blanks
between closing and opening parentheses.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel