Re: [Xen-devel] [PATCH 6/6] x86/cpuid: Offer ITSC to domains which are automatically non-migrateable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.01.17 at 12:40, <andrew.cooper3@xxxxxxxxxx> wrote:
> Dom0 doesn't have a toolstack to explicitly decide that ITSC is safe to offer.
> For domains which are constructed with disable_migrate set, offer ITSC
> automatically.

I'm afraid "constructed" is ambiguous here: To me, construction means
more than just domain_create(), i.e. includes all of the domctls the
tool stack issues until unpausing the domain the first time. Yet
XEN_DOMCTL_disable_migrate being among those isn't being covered
here. As to alternative wording, I would have wanted to suggest
"created", but I'm not convinced this is much less ambiguous.

> This is important for HVM-based dom0, and for when cpuid faulting is imposed
> on the control domain.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

The change itself is certainly fine:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel