Re: [Xen-devel] [PATCH] x86emul: VEX.B is ignored in compatibility mode

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/01/17 13:20, Jan Beulich wrote:
>
>>> @@ -2235,7 +2241,7 @@ x86_decode(
>>>                          break;
>>>                      }
>>>                  }
>>> -                if ( mode_64bit() && !vex.r )
>>> +                if ( !vex.r )
>>>                      rex_prefix |= REX_R;
>>>  
>>>                  ext = vex.opcx;
>>>
>> What is the purpose of this change? I doesn't appear to be related to
>> the rest of the patch.
> It is related - see the first half of the first sentence of the description
> (still visible above).

Ah ok, in which case it is simply an optimisation rather than a
functional change.

With that at least mentioned in the commit message, Reviewed-by: Andrew
Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel