Re: [Xen-devel] [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On Mon, Jan 16, 2017 at 3:16 PM, Daniel Kiper <daniel.kiper@xxxxxxxxxx> wrote:
> On Mon, Jan 16, 2017 at 09:28:45AM -0500, Doug Goldstein wrote:
>> On 1/16/17 9:11 AM, Daniel Kiper wrote:
>> > On Mon, Jan 16, 2017 at 08:41:08AM -0500, Doug Goldstein wrote:
>> >> On 1/16/17 7:50 AM, Daniel Kiper wrote:
>> >>> I would prefer to not have this patch series applied because it will 
>> >>> make me
>> >>> more difficult to prepare v12. I hope that I will post it in about 2 
>> >>> weeks.
>> >>> Though I am going to take into account all comments posted by Doug for 
>> >>> v11.

[snip]

>> >> Why? They're the first 4 patches remaining of your series. It'll
>> >> literally be the following commands:
>> >>
>> >> git fetch origin
>> >> git rebase origin/staging
>> >
>> > If you changed something then probably this is not so simple.
>> > Second, Jan asked me to reorder some patches in the series.
>> > Last but not least, your patch series does not contain whole
>> > functionality which is needed to properly load Xen using
>> > multiboot2 protocol on most EFI platforms. So, as above.
>> > Though I appreciate your feedback and I will take all
>> > your changes into account.

[snip]

>> Yes there are some code changes which is the point of me sending this.
>> But the work for you is the same as having to rebase your series over
>> the past few years. Its still a rebase. Its the same thing that everyone
>> submitting patches has to do when they submit another version of their
>> patches.
>
> Yes, I know. It is always easy to say. And I do not know why you are in
> such a hurry. Could not you wait 1-2 weeks?

I can't speak to the technical merits of Doug's patch, but I have to
say I'm not very happy with this way of interacting.  No one should be
able to block other people's valid contributions from going in to the
tree for their own convenience -- it discourages contribution and sets
the incentives all wrong.  Doing a difficult rebase is something
everyone has to do sometimes; and it's not clear that it *will* be
difficult, as it sounds like Daniel hasn't even tried it.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel