Re: [Xen-devel] [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross <jgross@xxxxxxxx>]

On 18/01/17 15:47, Wei Liu wrote:
> On Wed, Jan 18, 2017 at 01:47:17PM +0100, Juergen Gross wrote:
>> On 18/01/17 13:41, Wei Liu wrote:
>>> On Wed, Jan 18, 2017 at 01:33:48PM +0100, Juergen Gross wrote:
>>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>>> The aim is to test for correctness and performance.
>>>>
>>>> Add a test program containing some tests meant to be run against any
>>>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>>>
>>>> It is using libxenstore for access to xenstore and supports multiple
>>>> tests to be either selected all or individually. All tests are using
>>>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>>>> tests. This allows multiple instances of the program to run in
>>>> parallel.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>
>>> Thank you for doing this work!
>>>
>>> The only complaint I have is the code seems to be mixing hypervisor and
>>> toolstack coding style.
>>
>> Sorry, I don't see it. Where do I use coding style not compliant to
>> ./CODING_STYLE ?
>>
> 
> +static int test_dir_init(uintptr_t par)
> +{
> +    unsigned int i;
> +
> +    for (i = 0; i < WRITE_BUFFERS_N; i++)
> 
> Here and a bunch of other places.

Aah, okay. Missed those, yes.

> There are places where there is space after '('. It looks to me you
> wished to follow hypervisor side coding style.

Yep. That was the plan.

I'll update those with V2.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel