[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 4/8] dm_op: convert HVMOP_set_pci_intx_level, HVMOP_set_isa_irq_level, and...


  • To: Paul Durrant <paul.durrant@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Date: Wed, 18 Jan 2017 14:20:01 -0500
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 18 Jan 2017 19:20:07 +0000
  • Ironport-phdr: 9a23:mZCtGhVlVYQ49fxZ4vDzX8lSA/3V8LGtZVwlr6E/grcLSJyIuqrYZRSAvqdThVPEFb/W9+hDw7KP9fuxBSpbsN3Y6ihKWacPfidNsd8RkQ0kDZzNImzAB9muURYHGt9fXkRu5XCxPBsdMs//Y1rPvi/6tmZKSV3wOgVvO+v6BJPZgdip2OCu4Z3TZBhDiCagbb9oIhi7qQrcutMYjIZmJao91wXFrmdVcOlK2G1kIk6ekQzh7cmq5p5j9CpQu/Ml98FeVKjxYro1Q79FAjk4Km45/MLkuwXNQguJ/XscT34ZkgFUDAjf7RH1RYn+vy3nvedgwiaaPMn2TbcpWTS+6qpgVRHlhDsbOzM/7WrakdJ7gr5Frx29phx/24/Ub5+TNPpiZaPWYNcWSXNcUspNSyBNB4WxYIUVD+oFIO1WsY/zqVUTphe6HAWgGv/jxjpOi3Tr36M1zv4hHBnb0gI+EdIAsHPUotb7OqgcXu+6zrXHwzrYYvNK2zrw8pTEfgwvrPyMW797bMrfyVMoFwPAlliep5bqPzWU1usTt2iQ8uRuWvyygGAmsQF+uCKgxskxgYTOm40VxU3L+jt2wIYvP9K1U1J7YN64H5tQsCGWLY12Qtg4TG1ytyY6zaMGtIe9cSMXy5on3wbSZ+GIfoWH+B7uVPudLS1miH9qZr6znQu+/E69wePmTMa0ykxFri9dn9nJsXACygLc59CcSvt44kehwTGP1x3P6u1cIUA7i67bK5k5z74sjJUTq0XDHjLtmEnskK+Xdlkr+uiv6+j9ZLXpuoScOJNuhgH7M6QuntSzAeU+MgcQQ2iW4fmw2bLs8EHjQLhGk+c6nrfWvZzEP8gXu7a1AwpP3YYi7xa/AS2m0NMdnXQfMV1Fdw+IgJbmO1HUOv/1Fuu/glSwnzdrwPDKJLvhAo7XIXTZn7fheqh951ZGyAUv1dBf+45UCrYZLfLrQEDxqdjYAgUkPAyp2ebnEs9y1oUCWW+UHqCZMb/SsUWJ5uMgOeWDeIgVuDPlIfg/+/HulWM5mUMafaSx0poYdna4Eu17LEqHf3rjnNMBHHwOvgo/V+zqlEaCXSRcZnmsWaI8/is7CIWkDYjdWo+tnKaN3CChHp1ZfmpGEEyDEW/0d4WYXPcBcCOSLdVnkjAeV7iuUZMu1RK1tA/9zbpqNfTb+jACuZ3/1dh1+/fTlRA99DBuE8ud1GSNRXlunmwUXz82wLx/oUtlx1iZ16h3nuZYGsJd5v9TTgg6Mpncz/RkBNDoVA/MZcuGSFe6QtW8ADEwQcg9zMMJY0Z4SJ2eiUX71jeuS5MIjaaCAoB8prrVwny3K9tn0X/AyIEqjkU8Q9sJPmqj0Oo35wXVQoLEjUidv6KrbrgHmj7A8n+ZymiDt10eVxR/AovfWnVKSkLQrNn9rm/PB5C0AL0pel9NxsKPJbFDQsH4hlVBAvH4MZLRZHznyDT4PgqB2r7ZNNmiQG4axiiITRFeyw0=
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 01/17/2017 12:29 PM, Paul Durrant wrote:
... HVMOP_set_pci_link_route

These HVMOPs were exposed to guests so their definitions need to be
preserved for compatibility. This patch therefore updates
__XEN_LATEST_INTERFACE_VERSION__ to 0x00040900 and makes the HVMOP
defintions conditional on __XEN_INTERFACE_VERSION__ less than that value.

NOTE: This patch also widens the 'domain' parameter of
      xc_hvm_set_pci_intx_level() from a uint8_t to a uint16_t.

Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

This patch (and the previous one) remove some of the permissions from
the create_domain_common macro without adding the replacement permission.
This would be a problem if the domain builder code used them, but a quick
grep seems to say that they're not actually used by the domain builder.
It looks like this ended up as a bonus improvement from this change.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.