[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 4/6] tools: expand export.h with VMLINUX_SYMBOL()
- To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- Date: Thu, 19 Jan 2017 12:04:08 +0100
- Cc: gnomes@xxxxxxxxxxxxxxxxxxx, dalias@xxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, jkosina@xxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, ming.lei@xxxxxxxxxxxxx, heiko.carstens@xxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, paulus@xxxxxxxxx, mpe@xxxxxxxxxxxxxx, hpa@xxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx, wangnan0@xxxxxxxxxx, mchehab@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, markus.heiser@xxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, will.deacon@xxxxxxx, korea.drzix@xxxxxxxxx, x86@xxxxxxxxxx, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, dsahern@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, dvhart@xxxxxxxxxxxxx, bp@xxxxxxx, linux@xxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, keescook@xxxxxxxxxxxx, arnd@xxxxxxxx, realmz6@xxxxxxxxx, jani.nikula@xxxxxxxxx, linux@xxxxxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, npiggin@xxxxxxxxx, acme@xxxxxxxxxx, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, bp@xxxxxxxxx, rostedt@xxxxxxxxxxx, jpoimboe@xxxxxxxxxx, namhyung@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, mcb30@xxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxx, jgross@xxxxxxxx, chris@xxxxxxxxxx, pebolle@xxxxxxxxxx, tony.luck@xxxxxxxxx, konrad.wilk@xxxxxxxxxx, jcmvbkbc@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, dmitry.torokhov@xxxxxxxxx, adrian.hunter@xxxxxxxxx, luto@xxxxxxxxxxxxxx, ak@xxxxxxxxxxxxxxx, mmarek@xxxxxxxx, msalter@xxxxxxxxxx, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, joro@xxxxxxxxxx
- Delivery-date: Thu, 19 Jan 2017 11:04:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Sun, Jan 15, 2017 at 01:12:13PM -0800, Luis R. Rodriguez wrote:
> This will be used later by the linker-table userspace sandbox.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> ---
> tools/include/linux/export.h | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/tools/include/linux/export.h b/tools/include/linux/export.h
> index d07e586b9ba0..cb7d6b490e08 100644
> --- a/tools/include/linux/export.h
> +++ b/tools/include/linux/export.h
> @@ -1,6 +1,28 @@
> #ifndef _TOOLS_LINUX_EXPORT_H_
> #define _TOOLS_LINUX_EXPORT_H_
>
> +/*
> + * Export symbols from the kernel to modules. Forked from module.h
> + * to reduce the amount of pointless cruft we feed to gcc when only
> + * exporting a simple symbol or two.
You copied it, yet did not remove it from the original?
> + *
> + * Try not to add #includes here. It slows compilation and makes kernel
> + * hackers place grumpy comments in header files.
Define "slows" please. I doubt it is measurable, and so, why even
mention it here?
thanks,
greg k-h
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
