Re: [Xen-devel] [PATCH v7 03/14] ranges.h: add helpers to build and identify Linux section ranges

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Sun, Jan 15, 2017 at 01:10:46PM -0800, Luis R. Rodriguez wrote:
> Section ranges are on one of the types of custom sections
> types used in Linux.

Argh, come on, proof-read your changelog text please!

> This provides a series of helpers for
> defining them and using them. Most importantly this also
> enables us to avoid modifying the linker script when we
> add a new section range.

Also pick a line width and stick to it!

> It turns out a lot of custom sections are actually section ranges,
> and these are typically spelled out in their architecture specific
> asm/sections.h file -- we enable architectures to override what asm
> is used for section ranges but start by default trusting the
> asm-generic version all around.
> 
> Although typically you will not want to have section ranges ordered
> we must use SORT() on vmlinux.lds.S for section ranges to enable us
> to extend a section range without modifying the linker script. To
> accomplish this we use a special order string for the first element of a
> section range -- the empty string "" (refer to __SECTION_RANGE_BEGIN()),
> then "~" for the last element (refer to __SECTION_RANGE_BEGIN()). If
> you use the "any" order for elements in between and use SORT() you end
> up keeping any added element in between and a reference to the
> beginning and end of the section range without requiring custom linker
> script modifications. Specific order annotations are also supported
> to help construct synthetic functions, a demo for which will be provided
> later.

Again, split your documentation from your coding changes to make it
easier to review one or the other.

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel