[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v12 06/10] x86: change default load address from 1 MiB to 2 MiB



On Fri, Jan 20, 2017 at 01:49:46AM -0700, Jan Beulich wrote:
> >>> On 20.01.17 at 05:06, <cardoe@xxxxxxxxxx> wrote:
> > On 1/19/17 8:34 PM, Daniel Kiper wrote:
> >> Subsequent patches introducing relocatable early boot code play with
> >> page tables using 2 MiB huge pages. If load address is not aligned at
> >> 2 MiB then code touching such page tables must have special cases for
> >> start and end of Xen image memory region. So, let's make life easier
> >> and move default load address from 1 MiB to 2 MiB. This way page table
> >> code will be nice and easy. Hence, there is a chance that it will be
> >> less error prone too... :-)))
> >>
> >> Additionally, drop first 2 MiB mapping from Xen image mapping.
> >> It is no longer needed.
> >>
> >> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> >> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> >
> > FWIW, I can't find where I offered my R-b for this patch. Its part of
> > the series I've said fails on my hardware.
>
> Looks like you had responded to v11 00/13 without naming specific
> patches the tag would apply to, so I think Daniel legitimately applied
> it to the entire series. Whether he should have dropped it again
> after your report of things not working is kind of fuzzy, unless at
> some point you've explicitly withdrawn them (which I don't recall
> you having done).

Thanks Jan. Here is the exact email:

https://lists.xen.org/archives/html/xen-devel/2016-12/msg02151.html

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.