Re: [Xen-devel] [PATCH 6/6] x86/cpuid: Only recalculate the shared feature bits once

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.01.17 at 20:40, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -165,6 +153,8 @@ static void recalculate_xstate(struct cpuid_policy *p)
>  
>  static void recalculate_common(struct cpuid_policy *p)
>  {
> +    p->extd.e1d &= ~CPUID_COMMON_1D_FEATURES;
> +
>      switch ( p->x86_vendor )
>      {
>      case X86_VENDOR_INTEL:
> @@ -177,6 +167,8 @@ static void recalculate_common(struct cpuid_policy *p)
>          p->extd.vendor_ebx = p->basic.vendor_ebx;
>          p->extd.vendor_ecx = p->basic.vendor_ecx;
>          p->extd.vendor_edx = p->basic.vendor_edx;
> +
> +        p->extd.e1d |= p->basic._1d & CPUID_COMMON_1D_FEATURES;
>          break;
>      }
>  }

Coming back to the name of this function, with this new addition in
mind, perhaps recalculate_extd_common()?

Independent of this the patch here is
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel