Re: [Xen-devel] [PATCH v12 02/10] x86: add multiboot2 protocol support

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/01/17 17:24, Daniel Kiper wrote:
> On Fri, Jan 20, 2017 at 04:52:30PM +0000, Andrew Cooper wrote:
>>
>> here please?
> Will do.
>
>> With this, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Thanks!
>
>> With this patch present, should legacy booting with MB2 work properly?
>> If so, I have a good mind to take the patch now so it can get better
>> testing (at which point I can fix up this one issue).

I have confirmed that MB2 seems to work for me, with a few extra
diagnostics in reloc.c

(XEN) Bootloader: GRUB 2.02~beta2, MB protocol 2

> Yep, however, you have to remember that there is no support for
> relocatable images here. It is added by subsequent patches.

Using MB2 as the boot protocol is orthogonal to supporting relocation of
the images.  The former a useful piece of functionality to have even in
the absence of the latter.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel