[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v7 06/14] firmware/Makefile: force recompilation if makefile changes
- To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Date: Mon, 23 Jan 2017 17:12:45 +0100
- Cc: gnomes@xxxxxxxxxxxxxxxxxxx, dalias@xxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, jkosina@xxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, ming.lei@xxxxxxxxxxxxx, heiko.carstens@xxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, paulus@xxxxxxxxx, mpe@xxxxxxxxxxxxxx, hpa@xxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx, wangnan0@xxxxxxxxxx, mchehab@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, markus.heiser@xxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, will.deacon@xxxxxxx, korea.drzix@xxxxxxxxx, x86@xxxxxxxxxx, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, dsahern@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, dvhart@xxxxxxxxxxxxx, bp@xxxxxxx, linux@xxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, keescook@xxxxxxxxxxxx, arnd@xxxxxxxx, realmz6@xxxxxxxxx, jani.nikula@xxxxxxxxx, linux@xxxxxxxxxxxxxxxxxx, rusty@xxxxxxxxxxxxxxx, npiggin@xxxxxxxxx, acme@xxxxxxxxxx, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, bp@xxxxxxxxx, rostedt@xxxxxxxxxxx, jpoimboe@xxxxxxxxxx, namhyung@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, mcb30@xxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, alan@xxxxxxxxxxxxxxx, jgross@xxxxxxxx, chris@xxxxxxxxxx, pebolle@xxxxxxxxxx, tony.luck@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, dwmw2@xxxxxxxxxxxxx, dmitry.torokhov@xxxxxxxxx, adrian.hunter@xxxxxxxxx, luto@xxxxxxxxxxxxxx, ak@xxxxxxxxxxxxxxx, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, mmarek@xxxxxxxx, msalter@xxxxxxxxxx, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, joro@xxxxxxxxxx
- Delivery-date: Mon, 23 Jan 2017 16:13:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Thu, Jan 19, 2017 at 12:19:15PM +0100, Greg KH wrote:
> On Sun, Jan 15, 2017 at 01:10:49PM -0800, Luis R. Rodriguez wrote:
> > If you modify the target asm we currently do not force the
> > recompilation of the firmware files. The target asm is in
> > the firmware/Makefile, peg this file as a dependency to
> > require re-compilation of firmware targets when the asm
> > changes.
> >
> > v3: introduced in this series
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > ---
> > firmware/Makefile | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/firmware/Makefile b/firmware/Makefile
> > index e297e1b52636..fa3e81c2a97b 100644
> > --- a/firmware/Makefile
> > +++ b/firmware/Makefile
> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@
> > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
> > include/config/ppc32.h include/config/ppc64.h \
> > include/config/superh32.h include/config/superh64.h \
> > - include/config/x86_32.h include/config/x86_64.h)
> > + include/config/x86_32.h include/config/x86_64.h \
> > + firmware/Makefile)
> >
> > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps)
> > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@))
>
> I don't understand why this patch is in this series :(
I've taken it out and it has now been routed via kbuild folks as you
requested.
Thanks!
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
