[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Qemu-devel] [PATCH 0/3] xen-platform: disk unplug modifications
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/3] xen-platform: disk unplug modifications Message-id: 1485257020-18542-1-git-send-email-paul.durrant@xxxxxxxxxx === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1485257020-18542-1-git-send-email-paul.durrant@xxxxxxxxxx -> patchew/1485257020-18542-1-git-send-email-paul.durrant@xxxxxxxxxx Switched to a new branch 'test' dbab6a0 xen-platform: add missing disk unplug option a6063c7 xen-platform: add support for unplugging NVMe disks... 3e8c26d xen-platform: re-structure unplug_disks === OUTPUT BEGIN === Checking PATCH 1/3: xen-platform: re-structure unplug_disks... ERROR: braces {} are necessary for all arms of this statement #36: FILE: hw/i386/xen/xen_platform.c:113: + if (!strcmp(d->name, "xen-pci-passthrough")) [...] total: 1 errors, 0 warnings, 45 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/3: xen-platform: add support for unplugging NVMe disks...... Checking PATCH 3/3: xen-platform: add missing disk unplug option... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@xxxxxxxxxxxxx _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |