Re: [Xen-devel] [PATCH] x86emul/test: don't use *_len symbols

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jan 24, 2017 at 08:02:23AM -0700, Jan Beulich wrote:
> ... as they don't work as intended with -fPIC.
> 
> I did prefer them over *_end ones at the time because older gcc would
> cause .L* symbols to be public, due to issuing .globl for all
> referenced externals. And labels at the end of instructions collide
> with the ones at the start of the next instruction, making disassembly
> harder to grok. Luckily recent gcc no longer issues those .globl
> directives, and hence .L* labels, staying local by default, no longer
> get in the way.
> 
> Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Tested-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel