[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/7] x86emul/test: remove extraneous commas in debug messages



On Wed, Jan 25, 2017 at 09:33:05AM -0700, Jan Beulich wrote:
> >>> On 25.01.17 at 16:44, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/tools/tests/x86_emulator/test_x86_emulator.c
> > +++ b/tools/tests/x86_emulator/test_x86_emulator.c
> > @@ -42,7 +42,7 @@ static int read(
> >      struct x86_emulate_ctxt *ctxt)
> >  {
> >      if ( verbose )
> > -        printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, 
> > bytes);
> > +        printf("** %s(%u, %p, %u)\n", __func__, seg, (void *)offset, 
> > bytes);
> 
> Back when these got added, Andrew did explain why he put them
> there.
> 

Eh, OK. If there is a reason for this, I will just drop this patch. It's
not essential anyway.

It just looks rather odd to me to have so many extraneous commas. ;-)

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.