On 25 January 2017, at 17:54, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
>
>On Wed, 25 Jan 2017, Paul Durrant wrote:
>> > -----Original Message-----
>> > From: Stefano Stabellini [mailto:sstabellini@xxxxxxxxxx]
>> > Sent: 24 January 2017 23:49
>> > To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
>> > Cc: qemu-devel@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; Stefano
>> > Stabellini <sstabellini@xxxxxxxxxx>; Anthony Perard
>> > <anthony.perard@xxxxxxxxxx>; Michael S. Tsirkin <mst@xxxxxxxxxx>; Paolo
>> > Bonzini <pbonzini@xxxxxxxxxx>; Richard Henderson <rth@xxxxxxxxxxx>;
>> > Eduardo Habkost <ehabkost@xxxxxxxxxx>; olaf@xxxxxxxxx
>> > Subject: Re: [PATCH v2 2/3] xen-platform: add support for unplugging NVMe
>> > disks...
>> >
>> > On Tue, 24 Jan 2017, Paul Durrant wrote:
>> > > ...not just IDE and SCSI.
>> > >
>> > > This patch allows the Xen tool-stack to fully support of NVMe as an
>> > > emulated disk type.
>> > >
>> > > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
>> >
>> > Please update docs/misc/hvm-emulated-unplug.markdown in the Xen
>> > repository first. It might be also worth clarifying that `1` actually
>> > means all disks, not just IDE disks. Then, please add a reference to
>> > that commit in the description of this patch.
>> >
>>
>> Patch posted to remove 'IDE' from the documentation for value '1'. Awaiting ack.
>Done.
>When you repost this patch, could you also add to the description a
>reference to the commit that enables NVMe in QEMU with Xen? I guess it
>is a libxl commit?
I
think
there is
a
chicken
and egg
issue
here. Wei
wanted
to ensure
that
QEMU is
able
to unplug
NVMe
drives
before
accepting
my patch
to
libxl.
Paul
>> > > ---
>> > > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> > > Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
>> > > Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
>> > > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>> > > Cc: Richard Henderson <rth@xxxxxxxxxxx>
>> > > Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>
>> > > ---
>> > > hw/i386/xen/xen_platform.c | 1 +
>> > > 1 file changed, 1 insertion(+)
>> > >
>> > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
>> > > index f50915f..7d41ebb 100644
>> > > --- a/hw/i386/xen/xen_platform.c
>> > > +++ b/hw/i386/xen/xen_platform.c
>> > > @@ -120,6 +120,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d,
>> > void *o)
>> > > break;
>> > >
>> > > case PCI_CLASS_STORAGE_SCSI:
>> > > + case PCI_CLASS_STORAGE_EXPRESS:
>> > > object_unparent(OBJECT(d));
>> > > break;
>> > >
>> > > --
>> > > 2.1.4
>> > >
>>
>
