Re: [Xen-devel] [PATCH 3/5] hotplug/linux: Improve iptables logic

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Sylvain Munaut writes ("Re: [PATCH 3/5] hotplug/linux: Improve iptables logic"):
> I used the "any" keywords because when you add v6 you need to
> differentiate the case "none" allowed and "any" allowed to support the
> case where only v6 or only v4 is allowed. So you can't just rely on
> having an empty variable any more since it's more a "tri-state".

I think this comes out in the wash in my approach.  It is still
necessary to test an address for v4 or v6 format in the addition loop.

> I'd have to see how it works with v6 and user customization but I'm
> not going to implement the v6 and redo all the testing purely to see
> if it's at best equivalent in my eyes.

If you have a test setup, and I redid the v6 things to meet your goals
as you explain above, would you retest it ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel