Re: [Xen-devel] [PATCH] x86/dmar: place the initdata annotation after the variable type

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.01.17 at 17:18, <roger.pau@xxxxxxxxxx> wrote:
> clang cannot cope with the annotation being in the middle of the variable
> declaration.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -871,8 +871,8 @@ struct user_rmrr {
>      u32 sbdf[MAX_USER_RMRR_DEV];
>  };
>  
> -static __initdata unsigned int nr_rmrr;
> -static struct __initdata user_rmrr user_rmrrs[MAX_USER_RMRR];
> +static unsigned int __initdata nr_rmrr;
> +static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR];

I'm sorry for not spotting this during review - while I wasn't aware
that this actively breaks clang, it's still stylistically better even with
gcc. I'm surprised though that (by implication) these are the only
offenders in our tree.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel