Re: [Xen-devel] [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Jan 26, 2017 at 12:09:30PM +0100, Dario Faggioli wrote:
> On Thu, 2017-01-26 at 12:02 +0200, Oleksandr Andrushchenko wrote:
> > Hi, Konrad!
> > 
> > First of all thank you very much for the valuable comments
> > 
> > and your time!
> > 
> > The number of changes (mostly in description) is going to
> > 
> > be huge, so do you think I can publish something like
> > 
> > "RFC v16" so we can discuss the updated patch?
> > 
> Konrad's call, but why you want to introduce the 'RFC' tag now? I'd
> just go with v16...

v16 please.
> 
> > On 01/24/2017 09:13 PM, Konrad Rzeszutek Wilk wrote:
> > > On Mon, Dec 05, 2016 at 03:05:29PM +0200, Oleksandr Andrushchenko
> > > wrote:
> > > > 
> > > > + * Example for the frontend running in domain 5, instance of the
> > > > driver
> > > > + * in the front is 0 (single or first PV driver), device id 2,
> > > > + * first stream (0):
> > > > + * /local/domain/<frontend_id>/device/vsnd/<drv_idx>/
> > > > + *         device/<dev_id>/stream/<stream_idx>/type = "p"
> > > > + * /local/domain/5/device/vsnd/0/device/2/stream/0/type = "p"
> > > Why do you need 'device' ?
> > just for clarity: the hierarchy of the sound driver would
> > be that a device may have multiple different streams.

That is kind of implied. You have an vsnd and underneath it
you can have multiplie directories with a number. Those
are the device numbers.

Not sure why you would need the 'device'?

Also if you look at both vbd and vif - they follow the same
pattern - if you have multiple devices, it is just the number
(no device).

Hence from an maintaince perspective I would rather you not
have the 'device' in there - as it clashes with the other
ring protocols formats general layout.

> > So, from readability POV I would still have "device" in place
> >  From xenstore documentation: "Data should generally be
> > human-readable for ease of management and debugging "
> > I assume this also applies to the structure as well
> >
> Perhaps:
> 
>  
> /local/domain/<frontend_id>/device/vsnd/<drv_idx>/dev-<dev_id>/stream-<stream_idx>/...
> 
> > > Could not this be:
> > > 
> > > /local/domain/5/device/vsnd/0/2/stream/0/type = "p" ?
> > then one has to know that "2" stands for device.
> > see above, I would keep "device" here
> > > > 
> 
>  /local/domain/5/device/vsnd/0/dev-2/stream-0/type = "p"
> 
> Or, with no '-':
> 
>  /local/domain/5/device/vsnd/0/dev2/stream0/type = "p"
> 
> Just my 2 cents...
> 
> Dario
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel