Re: [Xen-devel] [PATCH v5 6/9] xen/x86: parse Dom0 kernel for PVHv2

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Jan 27, 2017 at 05:22:03PM +0000, Roger Pau Monne wrote:
> On Thu, Jan 26, 2017 at 06:37:00AM -0700, Jan Beulich wrote:
> > >>> On 19.01.17 at 18:29, <roger.pau@xxxxxxxxxx> wrote:
> > > @@ -1959,12 +1960,146 @@ static int __init pvh_setup_p2m(struct domain *d)
> > >  #undef MB1_PAGES
> > >  }
> > >  
> > > +static int __init pvh_load_kernel(struct domain *d, const module_t 
> > > *image,
> > > +                                  unsigned long image_headroom,
> > > +                                  module_t *initrd, char *image_base,
> > > +                                  char *cmdline, paddr_t *entry,
> > > +                                  paddr_t *start_info_addr)
> > > +{
> > > +    char *image_start = image_base + image_headroom;
> > 
> > While for cmdline plain char is certainly fine, I think we should stop
> > abusing this type for image and image_base, even if this means
> > some further adjustments elsewhere. This really ought to be u8 or
> > unsigned char.
> 
> Done.

I've used void * because that's also used by the toolstack and involves less
changes.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel