Re: [Xen-devel] [PATCH 2/7] x86_emulate: lift a bunch of macros to header file

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 26, 2017 at 03:51:35AM -0700, Jan Beulich wrote:
> >>> On 25.01.17 at 16:44, <wei.liu2@xxxxxxxxxx> wrote:
> > Some of them can be shared between hypervisor and userspace fuzzing /
> > test code. Instead of lifting the ones as we need, lift them all.
> 
> While I appreciate the intention, I don't think we should start having
> the hypervisor build deal with potential (or actual, but differently
> named) duplicate defines. In particular, despite its location in the
> tree, xen/arch/x86/x86_emulate/x86_emulate.h is a header
> included by various other source files, representing the interface to
> the emulator. The definitions you move there aren't part of that
> interface. I think Andrew and I had agreed (Andrew, correct me if
> I'm wrong) that we would want to eliminate that duplication, but
> then fully, i.e. also covering what processor.h and msr-index.h
> (and maybe a few more headers) define. I.e. we'd like to introduce
> a header of x86 arch definitions which can be used in both the
> hypervisor and the test harness builds.
> 

I see. Let me go through all those flags and change x86emul to use the
ones in xen headers.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel